Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow: add coverage check configuration #114

Merged
merged 5 commits into from
Nov 1, 2023

Conversation

liuzengh
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (369c60d) 85.60258% compared to head (bb701f0) 85.52811%.

Additional details and impacted files
@@                 Coverage Diff                 @@
##                main        #114         +/-   ##
===================================================
- Coverage   85.60258%   85.52811%   -0.07448%     
===================================================
  Files            188         188                 
  Lines          16114       16114                 
===================================================
- Hits           13794       13782         -12     
- Misses          1755        1777         +22     
+ Partials         565         555         -10     
Flag Coverage Δ
unittests 85.52811% <ø> (-0.07448%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@liuzengh liuzengh closed this Oct 19, 2023
@liuzengh liuzengh reopened this Oct 19, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2023
@trpc-group trpc-group unlocked this conversation Oct 19, 2023
@liuzengh liuzengh closed this Oct 19, 2023
@liuzengh liuzengh reopened this Oct 19, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2023
@trpc-group trpc-group unlocked this conversation Oct 19, 2023
@@ -0,0 +1,4 @@
comment:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

默认设置不允许覆盖率下降。可以增加下覆盖率要求的配置,例如允许下降幅度1%

coverage:
status:
project:
default:
threshold: 1%

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm trying to modify the Global yml file under the trpc-group organization on the codecov platform, but I found that some settings have taken effect while others haven't.

coverage:
  precision: 5 // have taken effect
  range: // haven't  taken effect
  - 90.0
  - 100.0
  status:
    project:
      default:
        branches:
        - ^main$
        target: 100.0
        threshold: 0.0

Codecov provides a user interface to adjust a "Global YAML", which overrides the default settings in Codecov. It is applied to all repositories in the Global. Only Global administrators can adjust the Global YAML in Codecov. All changes are stored in history.

https://docs.codecov.com/docs/codecov-yaml#global-yaml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The configuration actually took effect, there might have been a delay before, which resulted in no observations being made.

@liuzengh liuzengh changed the title WIP: test codecov coverage(don't merge this pr) workflow: add coverage check configuration Oct 30, 2023
Copy link
Contributor

@sandyskies sandyskies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandyskies sandyskies merged commit da0e38e into trpc-group:main Nov 1, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants