Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toString() method for ForwardingInputFile and ForwardingOutputFile #17030

Merged

Conversation

findinpath
Copy link
Contributor

Description

While dealing with failure scenarios, it is helpful to see what file is causing the issue

io.trino.testing.QueryFailedException: Failed to read file: ForwardingInputFile{inputFile=s3://test-bucket/tpch/corrupt_table_y4fjmbitkt-a9f1d9ebba684cd8b19ddcdc58725c68/metadata/00002-c9681ed7-843a-4484-92ed-606ef7c07e75.metadata.json}

instead of

io.trino.testing.QueryFailedException: Failed to read file: io.trino.plugin.iceberg.fileio.ForwardingInputFile@2cdc22bb

Release notes

(x) This is not user-visible or docs only and no release notes are required.
( ) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label Apr 14, 2023
@findinpath findinpath requested review from ebyhr and krvikash April 14, 2023 09:55
@github-actions github-actions bot added the iceberg Iceberg connector label Apr 14, 2023
@findinpath findinpath force-pushed the findinpath/forwardinginputfile-tostring branch from fbd9474 to 1f9cddf Compare April 14, 2023 12:06
@findinpath findinpath changed the title Add toString() method to ForwardingInputFile Add toString() method Apr 14, 2023
@findinpath findinpath changed the title Add toString() method Add toString() method for ForwardingInputFile and ForwardingOutputFile Apr 14, 2023
@findinpath findinpath added the no-release-notes This pull request does not require release notes entry label Apr 14, 2023
@ebyhr ebyhr merged commit 094d965 into trinodb:master Apr 15, 2023
@github-actions github-actions bot added this to the 414 milestone Apr 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed iceberg Iceberg connector no-release-notes This pull request does not require release notes entry
Development

Successfully merging this pull request may close these issues.

3 participants