Document SAP system aggregate #988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
force-pushed
the
document-sap-system-aggregate
branch
from
18eec36 to
c522d2d
Compare
arbulu89
requested review from
fabriziosestito,
dottorblaster,
CDimonaco,
EMaksy,
jamie-suse,
nelsonkopliku and
rtorrero
dottorblaster
suggested changes
Nov 16, 2022
|
Thanks @dottorblaster , |
fabriziosestito
suggested changes
Nov 17, 2022
nelsonkopliku
approved these changes
Nov 17, 2022
EMaksy
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document SAP system aggregate code. I have included some additional documentation in the SAP application instance registering command, to explain how the application and database are associated.
This part of the code is a bit hidden, but I hope the new docs help a bit on that.
PD: We cannot put docs in the protocol code as it is a
defimpl, that's why it goes in the register command, which at the end looks an appropriate place