Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hover style to health icon #959

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Add hover style to health icon #959

merged 1 commit into from
Nov 7, 2022

Conversation

CDimonaco
Copy link
Member

Description

As the title suggest.

The hover style is consistent with the health boxes.

hover_icons_Dashboard

How was this tested?

Manually

@CDimonaco CDimonaco added ux javascript Pull requests that update Javascript code labels Nov 7, 2022
@CDimonaco CDimonaco self-assigned this Nov 7, 2022
jagabomb
jagabomb approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@jagabomb jagabomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... when the filled version of the health icons are dropped in then it will help to see the hover state of the icons... ;) @EMaksy

@CDimonaco CDimonaco merged commit 67c2da1 into main Nov 7, 2022
@CDimonaco CDimonaco deleted the hover_style_health_icon branch November 7, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jagabomb jagabomb jagabomb approved these changes

@dottorblaster dottorblaster Awaiting requested review from dottorblaster

@rtorrero rtorrero Awaiting requested review from rtorrero

@arbulu89 arbulu89 Awaiting requested review from arbulu89

Assignees

@CDimonaco CDimonaco

Labels
javascript Pull requests that update Javascript code ux
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CDimonaco @jagabomb