Cluster health when no checks are selected #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
requested review from
dottorblaster,
fabriziosestito,
rtorrero,
stefanotorresi and
nelsonkopliku
arbulu89
force-pushed
the
cluster-health-no-checks
branch
from
ef86f95 to
3efdeae
Compare
fabriziosestito
suggested changes
May 19, 2022
|
@fabriziosestito Suggested changes done: 86301ab Thanks dude! |
fabriziosestito
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is not any check selected, the cluster health is being still built aggregating the discovered health and the checks health, which is
uknownin this case. This creates an unexpected cluster health, as it would be unknown.With this change, when no checks are selected, the checks health is not used in the cluster health computation.
Besides that, I have improved the dashboards E2E tests to disable all checks in order to make the test more robuts