Streamline Pagination #3026
Merged
Streamline Pagination #3026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelsonkopliku
added
enhancement
gagandeepb
approved these changes
Sep 26, 2024
balanza
approved these changes
Sep 26, 2024
There was a problem hiding this comment.
LGTM
Thanks, I thought it would take more hassle to switch to vector icons.
About the PageNumberPagination: I'm keen to remove it as we are not using it now. We can always resume the code from the history. If you do, remember to also uninstall the react-paginate packages as it's used nowhere else.
balanza
force-pushed
the
pagination-icons
branch
from
fad7dc8 to
5fdd5c3
Compare
nelsonkopliku
force-pushed
the
pagination-icons
branch
from
5fdd5c3 to
6cc9060
Compare
nelsonkopliku
force-pushed
the
pagination-icons
branch
from
03c1d8d to
d0ab0ab
Compare
nelsonkopliku
force-pushed
the
pagination-icons
branch
from
d0ab0ab to
32c8fa8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses following Pagination aspects:
I kept the legacy Pagination as a
PageNumberPaginationcomponent. If no one against it I will remove in a follow up PR.How was this tested?
Existent tests.