Raise an error during SAML init if decryption fails #3021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is one scenario (at least) that if the decryption of the encrypted entries in the DB fails, the SAML initialization might fail. The encryption is based on the SECRET_KEY_BASE value, so if this value is changed during different bootups, the decryption will start failing.
This can happen for example if helm chart installation is used, and you install trento server, uninstall and install back again (without wiping out the pvc containing the DB), the secret key base is auto generated again, so this fails.
This patch simply aims to help improving the user message received if this "corner case" happens.
How was this tested?
Manually, it is really difficult to add automated tests for this.