Add a refresh button to the Activity Log page #3020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelsonkopliku
added
enhancement
balanza
approved these changes
Sep 25, 2024
| @@ -139,6 +141,15 @@ function ActivityLogPage() { | |||
| setSearchParams | |||
| )} | |||
| /> | |||
| <Button | |||
| type="primary-white" | |||
There was a problem hiding this comment.
issue: Maybe the button is too big?
We may prefer something lighter like
Suggested change
| type="primary-white" | |
| type="link" |
There was a problem hiding this comment.
Addressed like this 7cf3134
nelsonkopliku
force-pushed
the
activity-log-refresh-button
branch
from
20cff95 to
46d9a63
Compare
gagandeepb
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a
Refreshbutton to the Activity Log page.Visually this is the best we can come with at the moment and the auto-refresh feature is intentionally left out.
We will need to revisit the arrangements of filters and actions in the activity log page when introducing filters by metadata.
How was this tested?
Automated tests.