Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable SAML messages signing #2995

Merged
merged 2 commits into from
Sep 25, 2024
Merged

Enable SAML messages signing #2995

merged 2 commits into from
Sep 25, 2024

Conversation

arbulu89
Copy link
Contributor

@arbulu89 arbulu89 commented Sep 18, 2024

Description

Enable SAML messages signing with SSL for dev environment.
Just it mimics better a real world application

I just uploaded the dev certs to the container_fixtures folder as they are related to keycloak.
I didn't think putting them in priv was the best.
I have uploaded the metadata.xml file as well, less things to worry about for developers (if the realm is changed, it must be changed of course)

But I accept proposals (maybe just priv/cert is the correct folder...)

@arbulu89 arbulu89 marked this pull request as ready for review September 18, 2024 13:25
Copy link
Member

@EMaksy EMaksy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arbulu89 arbulu89 added the env Create an ephimeral environment for the pr branch label Sep 23, 2024
@arbulu89 arbulu89 merged commit 360c813 into main Sep 25, 2024
122 checks passed
@arbulu89 arbulu89 deleted the enable-saml-signing branch September 25, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore env Create an ephimeral environment for the pr branch integration
Development

Successfully merging this pull request may close these issues.

3 participants