Adust length of "Results per page"-field #2968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Gonna do the other CSS things on this branch as well, since they are tiny, and I don't think it's necessary to bother you with review rapid-fire ^^ |
|
Idk how to test this without reproducing the math |
|
The PR env: https://2968.prenv.trento.suse.com/ |
janvhs
added
env
janvhs
force-pushed
the
pagination-adjustments
branch
from
9647b58 to
465b6eb
Compare
dottorblaster
suggested changes
Sep 13, 2024
jagabomb
reviewed
Sep 13, 2024
|
Oh thought we agreed on the other side. Gonna move it over and ping you :D |
janvhs
force-pushed
the
pagination-adjustments
branch
2 times, most recently
from
1162cd2 to
dc4c55c
Compare
|
@janvhs all good here, smash the green button 👍 |
This commit adjusts the length of the "Results per page"-field in the views containing pagination. The field now adjusts its size based on its content. For this, I use a margin on the chevron element, but utilising CSS' after pseudo class would be better
This commit shows the current item range as well as the total amount of items in the bottom of the table
The table should determine its empty state based on the filtered data, because that can be less than the unfiltered data
janvhs
force-pushed
the
pagination-adjustments
branch
from
852566c to
597c92a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adjusts the length of the "Results per page"-field in the views containing pagination. The field now adjusts its size based on its content. For this, I use a margin on the chevron element, but utilising CSS' after pseudo class would be better
Did you add the right label?
Remember to add the right labels to this PR.
How was this tested?
Visually