Table Header Alignment #2949
Merged
Table Header Alignment #2949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagabomb
force-pushed
the
table-header-alignment
branch
from
8aa0dfb to
0595675
Compare
dottorblaster
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tables displaying the text as left aligned for both the table header and rows had a slight misalignment of about 4px. This PR attempts to make the horizontal padding the same value for consistency purposes. There is also the inclusion of test to prevent values being changed independently and to prevent this issue resurfacing.
Before (Misalignment highlighted in red)
Changes
How was this tested?
Describe the tests that have been added/changed for this new behaviour.