Add date and time picker to <DateFilter />
#2867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balanza
force-pushed
the
ui-add-datepicker
branch
from
85a0527 to
3e7f9a7
Compare
balanza
changed the title
<DateFilter />
| function Tick() { | ||
| return ( | ||
| <span className="absolute inset-y-0 right-0 flex items-center pr-4"> | ||
| <svg |
There was a problem hiding this comment.
suggestion: we might use EOS_CHECK icon from eos icon-set.
There was a problem hiding this comment.
Good point. I'd rather do it in another PR, as we might also refactor the Filter component. I prepared it already: #2870
| @@ -160,6 +160,12 @@ export const Date = { | |||
| }, | |||
| }; | |||
|
|
|||
| export const DateTime = { | |||
| args: { | |||
| type: 'datetime-local', | |||
There was a problem hiding this comment.
praise: well done in leveraging browser's calendar.
balanza
force-pushed
the
ui-add-datepicker
branch
2 times, most recently
from
789b133 to
9ccc8da
Compare
nelsonkopliku
approved these changes
Aug 7, 2024
balanza
force-pushed
the
ui-add-datepicker
branch
from
9ccc8da to
f62f4e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a DateTime for selecting a specific date and time as a filter value.