Domain events activity frontend #2841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelsonkopliku
added
enhancement
nelsonkopliku
added
env
nelsonkopliku
added
env
nelsonkopliku
force-pushed
the
log-domain-events
branch
from
e0c8639 to
f50947e
Compare
nelsonkopliku
force-pushed
the
domain-events-activity-frontend
branch
from
9e9b8ad to
31c277e
Compare
nelsonkopliku
force-pushed
the
log-domain-events
branch
from
f50947e to
a17a387
Compare
nelsonkopliku
force-pushed
the
domain-events-activity-frontend
branch
2 times, most recently
from
af2ba56 to
c009c8b
Compare
nelsonkopliku
force-pushed
the
log-domain-events
branch
from
387465d to
4814ab6
Compare
nelsonkopliku
force-pushed
the
domain-events-activity-frontend
branch
from
c009c8b to
e3128a6
Compare
gagandeepb
reviewed
Aug 1, 2024
Comment on lines
23
to
30
| // Host events | ||
| HEARTBEAT_FAILED, | ||
| HEARTBEAT_SUCCEEDED, | ||
| HOST_CHECKS_HEALTH_CHANGED, | ||
| HOST_CHECKS_SELECTED, | ||
| HOST_DEREGISTERED, | ||
| HOST_DEREGISTRATION_REQUESTED, | ||
| HOST_DETAILS_UPDATED, |
There was a problem hiding this comment.
Possible opportunity to evaluate openapi front-end code generation here?
There was a problem hiding this comment.
Could be an option indeed. Let's see how it evolves.
Comment on lines
105
to
108
| [HOST_ADDED_TO_CLUSTER]: 'Host Added to Cluster', | ||
| [HEARTBEAT_FAILED]: 'Heartbeat Failed', | ||
| [HEARTBEAT_SUCCEEDED]: 'Heartbeat Succeeded', | ||
| [HOST_CHECKS_HEALTH_CHANGED]: 'Checks Health Changed', |
There was a problem hiding this comment.
This could potentially be a string manipulating function, I guess? Turning the event names into a string is a bit like writing a custom serializer, for the most part.
There was a problem hiding this comment.
Yes, it could be something like
const activityTypesLabels = _.fromPairs(
ACTIVITY_TYPES.map((type) => [
type,
type.split('_').map(_.capitalize).join(' '),
])
);However I'd like to get some more feedback on the rendered entries in order to figure out the transformation rule.
Additionally let's take into account that there is not yet a consistent pattern throughout all the activity types. But we can improve as we proceed.
nelsonkopliku
force-pushed
the
domain-events-activity-frontend
branch
3 times, most recently
from
1304bbf to
18a653f
Compare
nelsonkopliku
force-pushed
the
domain-events-activity-frontend
branch
from
18a653f to
932ab4d
Compare
balanza
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mapping messages/activity types/resources to the domain events activities in the UI.
I found it useful consolidating the mapping in one place.
As we iterate we'll figure out what kind of mapping should be moved from the frontend to the backend.
How was this tested?
Automated tests.