Default admin check with username #2840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CDimonaco
added
enhancement
CDimonaco
force-pushed
the
default_admin_check_with_username
branch
from
a8ba132 to
c41e06e
Compare
arbulu89
reviewed
Jul 30, 2024
arbulu89
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Hey @CDimonaco
It looks good to me.
Simply a comment about making the admin_username function maybe private.
About the ugliness, i understand that there must not be any other option.
If you researched it, and there isn't, go ahead. It is what it is
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the way we detect if a user is the default admin.
We used to check against the user id, checking from id == 1
We change the strategy in order to check against the username, the guarantees are the same but we don't assume the user id, this will be useful also in future scenarios when the admin will come from an external IDP and we can't be sure if it's the user with id 1 in our database.
How was this tested?
Automated tests