Add IP addresses netmask discovery and visualization #2793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arbulu89
force-pushed
the
add-netmask-ipaddresses
branch
from
bd58081 to
a37e533
Compare
arbulu89
added
env
arbulu89
force-pushed
the
add-netmask-ipaddresses
branch
from
e60c181 to
569d1a0
Compare
arbulu89
force-pushed
the
add-netmask-ipaddresses
branch
from
dd0b24a to
80dd7bb
Compare
EMaksy
reviewed
Jul 18, 2024
...es/scenarios/single-hana-single-app/e77ab524-c4e4-5381-bb59-5af8639d52a4_host_discovery.json
Show resolved
Hide resolved
EMaksy
approved these changes
Jul 18, 2024
CDimonaco
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Discover ip addresses netmask and implement visualization.
In order to not overload this small changes in the domain logic (which I have the gut feeling that at some point we will want to upgrade how we deal with network interfaces in general), i have added the logic in the projection itself.
This way, we simply serialize and deserialize ip address+netmask in the policy and projection (basically concat address with netmask).
And the domain and events stay untouched. At the end, changing events and domain is really sensitive, so if i can avoid with this little changes I prefer this way.
Maybe changing
commands/events/domainis a bit cleaner though.If you think we should include
netmasksin the domain, we can of course, but again, I'm not entirely sure if this will be the last time we play with network interfaces...Based on: trento-project/agent#346
How was this tested?
Tested with UT and e2e tests updated