Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Tooltip story #1307

Merged
merged 3 commits into from
Apr 6, 2023
Merged

Added Tooltip story #1307

merged 3 commits into from
Apr 6, 2023

Conversation

jagabomb
Copy link
Contributor

@jagabomb jagabomb commented Apr 6, 2023

Description

Added Tooltip story to enhance Storybook. I also noticed some issues with Tooltip component which is solved by wrapping the component into additional divs so that it will to display properly.

How was this tested?

Visually

Screenshot 2023-04-06 at 11 07 55

Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@EMaksy EMaksy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A great start, maybe we can add more cases on a later iteration.
Other than that, LGTM!

@jagabomb jagabomb merged commit c1e3028 into main Apr 6, 2023
@jagabomb jagabomb deleted the tooltip_story branch April 6, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants