Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update commanded and commanded_ecto_projections #1227

Merged
merged 2 commits into from
Mar 2, 2023
Merged

Update commanded and commanded_ecto_projections #1227

merged 2 commits into from
Mar 2, 2023

Conversation

fabriziosestito
Copy link
Member

@fabriziosestito fabriziosestito commented Mar 1, 2023 •
edited
Loading

Updates commanded and commanded_ecto_projections to the next minor.
This removes warnings in the projectors introduced by Elixir v1.14.x

@fabriziosestito fabriziosestito force-pushed the update-commanded-ecto-projections branch from 34029b4 to 0f3dc7b Compare March 1, 2023 18:34
@fabriziosestito fabriziosestito changed the title Update commanded_ecto_projections Update commanded and commanded_ecto_projections Mar 2, 2023
arbulu89
arbulu89 approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes and the description are missleading though. Because as far as I see commanded stays in the same version.

@fabriziosestito fabriziosestito merged commit b3cb6ff into main Mar 2, 2023
@fabriziosestito fabriziosestito deleted the update-commanded-ecto-projections branch March 2, 2023 07:26
@fabriziosestito
Copy link
Member Author

@arbulu89 thanks, pinned in the mix file as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arbulu89 arbulu89 arbulu89 approved these changes

@dottorblaster dottorblaster Awaiting requested review from dottorblaster

@nelsonkopliku nelsonkopliku Awaiting requested review from nelsonkopliku

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fabriziosestito @arbulu89