Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check base url injected into the client via global config object #1198

Merged
merged 4 commits into from
Feb 21, 2023

Conversation

CDimonaco
Copy link
Member

Description

The base url of the check service, was previously injected into the frontend via an env variable (WANDA_URL), populated at build time.

This behavior leads to a bug where the user cannot add the base url of the check service because that can be only set at assets build time, when we build the image basically. We need to give the user the ability to specify on which path/url is present the check service in their infrastructure. This can be a path "/check_service" or a full url like we can see on the development configuration.

This configuration is then used by axios to compose the base url of the checks frontend library.

This is similar to grafana public url handling.

Jest configuration updated to perform tests with the global config.

The helm chart needs to be updated.

How was this tested?

Automated tests

@CDimonaco CDimonaco added javascript Pull requests that update Javascript code elixir Pull requests that update Elixir code labels Feb 16, 2023
@CDimonaco CDimonaco self-assigned this Feb 16, 2023
Copy link
Contributor

@arbulu89 arbulu89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a superficial review, we would need to update the hack_to_trento guides, as we wouldn't depend anymore on the .env file and this is what the guides describes.
And we could even drop some dotenv dependencies as well

@CDimonaco
Copy link
Member Author

With a superficial review, we would need to update the hack_to_trento guides, as we wouldn't depend anymore on the .env file and this is what the guides describes. And we could even drop some dotenv dependencies as well

you're right, done!

@CDimonaco CDimonaco merged commit 347f3aa into main Feb 21, 2023
@CDimonaco CDimonaco deleted the check_base_url_global_config branch February 21, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
elixir Pull requests that update Elixir code javascript Pull requests that update Javascript code
Development

Successfully merging this pull request may close these issues.

4 participants