Fix e2e #1105
Merged
Fix e2e #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dottorblaster
force-pushed
the
fix-e2e
branch
from
102881e to
bd41bb7
Compare
|
best pr 2023 |
fabriziosestito
approved these changes
Jan 13, 2023
| return ( | ||
| <div className="w-64 w-72 top-16 mr-4" ref={ref}> | ||
| <div className="mt-1 relative"> | ||
| {value !== '' && ( | ||
| <button | ||
| type="button" | ||
| data-testid={`filter-${title}-clear`} |
There was a problem hiding this comment.
will we remember to remove testid related stuff?
There was a problem hiding this comment.
Right, I'll create a card for that
nelsonkopliku
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out opening a dropdown, selecting an item and then reopening it right after makes an end to end test extremely prone to flakiness.
In this PR we try to use the clear function of a filter, that should avoid the second dropdown interaction, therefore making the test more reliable.