Fix Checks results filters #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamie-suse
force-pushed
the
filter-fix
branch
from
16bb89f to
13afe6f
Compare
arbulu89
approved these changes
Dec 22, 2022
There was a problem hiding this comment.
Hey @jamie-suse ,
The code looks great! Thank you for adding tests ;)
I would appreciate a gif to see it working
| error, | ||
| expectations, | ||
| failedExpectations, | ||
| result: health, |
There was a problem hiding this comment.
Why this change from health to result?
We use health all around the frontend code.
Is it because the predicate function expects that?
There was a problem hiding this comment.
Yep that's correct, predicate() relies on result being present.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes changes to the new checks results filters from bd2f538.
Fixes #1064
How was this tested?
Added new tests for filtering in
ExecutionResults.test.jsx.