Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docker-compose ports and config #1015

Merged
merged 2 commits into from
Nov 28, 2022
Merged

Fix docker-compose ports and config #1015

merged 2 commits into from
Nov 28, 2022

Conversation

fabriziosestito
Copy link
Member

@fabriziosestito fabriziosestito commented Nov 28, 2022 •
edited
Loading

Related to: trento-project/wanda#105

Changes docker-compose forwarded ports and related config to avoid clashes with wanda.

The wanda environment is configured using the wanda compose port for rabbitmq.

dottorblaster
dottorblaster approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@dottorblaster dottorblaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nelsonkopliku
nelsonkopliku approved these changes Nov 28, 2022
View reviewed changes
Copy link
Member

@nelsonkopliku nelsonkopliku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

arbulu89
arbulu89 requested changes Nov 28, 2022
View reviewed changes
@fabriziosestito fabriziosestito merged commit a5e74d1 into main Nov 28, 2022
@fabriziosestito fabriziosestito deleted the fix-compose-ports branch November 28, 2022 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dottorblaster dottorblaster dottorblaster approved these changes

@nelsonkopliku nelsonkopliku nelsonkopliku approved these changes

@arbulu89 arbulu89 arbulu89 approved these changes

@CDimonaco CDimonaco Awaiting requested review from CDimonaco

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fabriziosestito @dottorblaster @nelsonkopliku @arbulu89