Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for Zig bindings #49

Merged
merged 13 commits into from
Aug 13, 2022
Merged

Conversation

noiryuh
Copy link
Contributor

@noiryuh noiryuh commented Aug 9, 2022

Using u64 for pointer is unsafe because it makes it easy for user to modify the address. Yes, it can happend with opaque too, but it requires casting, which they should know what they're doing before casting. It's same for current C bindings.

@noiryuh noiryuh changed the title clean code and make ref object use opaque Make Zig use opaque type Aug 10, 2022
@noiryuh noiryuh marked this pull request as ready for review August 10, 2022 07:40
@noiryuh noiryuh changed the title Make Zig use opaque type Better support for Zig bindings Aug 10, 2022
@noiryuh noiryuh changed the base branch from zig to master August 11, 2022 08:05
@treeform treeform merged commit fe68686 into treeform:master Aug 13, 2022
@noiryuh noiryuh deleted the zig-opaque branch August 13, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants