Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CA extension to strips (14_2_X) #159

Draft
wants to merge 8 commits into
base: from-CMSSW_14_2_0
Choose a base branch
from

Conversation

bdanzi
Copy link

@bdanzi bdanzi commented Jan 10, 2025

PR description:

This PR should introduce the usage of strips layers to the offline reco and HLT Cellular Automaton usage (same work done for 15_0_0_pre1):

  • the strip addition and the changes in performance are expected only if using the customizer customizeHLTforAlpakaStrip for HLT and stripNTupletFit for offline reco, final geometry (Geometry/CommonTopologies/interface/SimplePixelStripTopology.py) pairs is still work in progress
  • little gain in performance for the CA applied to pixel only due to the removal of minYsizeB1 and minYsizeB2 cuts + generalization of Kernel_simpleTripletCleaner
    Test on TTbar PU EOR3 TRK DPG v7:
    http://uaf-3.t2.ucsd.edu/~bdanzi/plots_pixelsOnlyValidation_AllCases/plots_hlt_hltPixel/effandfakePtEtaPhi.png where results in blue and red are produced with a cleaned 14_2_0 CMSSW release while the black one comes along with this PR changes

PR validation:

Before submitting I was checking

  • basic test procedure suggested in the CMSSW PR instructions, some of them still failing with exception like:
A std::exception was thrown.
Connection on "frontier://(preferipfamily=0)(proxyconfigurl=http://grid-wpad/wpad.dat)(backupproxyurl=http://cmst0frontier.cern.ch:3128)(backupproxyurl\
=http://cmst0frontier1.cern.ch:3128)(backupproxyurl=http://cmst0frontier2.cern.ch:3128)(backupproxyurl=http://cmsbpfrontier.cern.ch:3128)(backupproxyur\
l=http://cmsbpfrontier1.cern.ch:3128)(backupproxyurl=http://cmsbpfrontier2.cern.ch:3128)(backupproxyurl=http://cmsbproxy.fnal.gov:3128)(serverurl=http:\
//cmsfrontier.cern.ch:8000/FrontierProd)(serverurl=http://cmsfrontier1.cern.ch:8000/FrontierProd)(serverurl=http://cmsfrontier2.cern.ch:8000/FrontierPr\
od)(serverurl=http://cmsfrontier3.cern.ch:8000/FrontierProd)(serverurl=http://cmsfrontier4.cern.ch:8000/FrontierProd)/CMS_CONDITIONS" cannot be establi\
shed ( CORAL : "ConnectionPool::getSessionFromNewConnection" from "CORAL/Services/ConnectionService" )
----- End Fatal Exception -------------------------------------------------

@bdanzi bdanzi self-assigned this Jan 10, 2025
@slava77
Copy link

slava77 commented Jan 10, 2025

it's probably more practical to submit this upstream to cms-sw/cmssw already; can name this as "RFC" or a draft if some tests/updates are not completed.

The code base is ~ decoupled from mkfit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants