Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#c0eutiqt]/1028 fix discreetly #10

Merged
merged 1 commit into from
Nov 10, 2020
Merged

[#c0eutiqt]/1028 fix discreetly #10

merged 1 commit into from
Nov 10, 2020

Conversation

minhducvt293
Copy link
Contributor

@minhducvt293 minhducvt293 commented Nov 4, 2020 •
edited
Loading

What does this Pull Request do?

  • update discreetly to use google-cloud-kms version >=2.0.0 and <3.0.0
  • update tests for test-gcp accordingly
  • update docs for new changes
  • update .envrc for python 3.7.3
  • add template for making commit and PRs

prepare to release discreetly v0.2.0

How should this be validated?

  1. uninstall google-cloud-kms
pip uninstall google-cloud-kms
  1. install dependencies:
pip install -r requirements.txt
  1. run pytest should be sufficient
pytest
  1. Follow the README.md and verify those functions work correctly.

Checklist

  • You've fetched and rebased your branch on an up-to-date version master
  • PR contains new tests relevant for the feature/problem this PR is addressing
  • All tests and linting pass
  • Your commits have been squashed/rebased/etc. for reviewer clarity

Additional Notes:

This PR is for release of v0.2.0 which supports python 3 only
Other PR (#11) is for release of v0.1.2 which also supports python 2

Interested parties

@ghosalya as main reviewer
@eddies

@minhducvt293 minhducvt293 mentioned this pull request Nov 4, 2020
Merged
4 tasks
@minhducvt293 minhducvt293 force-pushed the cOeutIqt/1028-fix-discreetly branch 4 times, most recently from 7e19bb1 to 23c2d00 Compare November 4, 2020 09:18
@minhducvt293 minhducvt293 requested a review from ghosalya November 4, 2020 09:21
ghosalya
ghosalya requested changes Nov 10, 2020
View reviewed changes
@minhducvt293
[#cOeutIqt] 1028 fix discreetly
c22fd98 
- update discreetly to use google-cloud-kms version >=2.0.0 and <3.0.0
- update tests for test-gcp accordingly
- update docs for new changes
- update .envrc for python 3.7.3
@minhducvt293 minhducvt293 force-pushed the cOeutIqt/1028-fix-discreetly branch from af82140 to c22fd98 Compare November 10, 2020 10:19
ghosalya
ghosalya approved these changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@ghosalya ghosalya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

note: we are expecting a release pr for 0.2.0 after this PR

@ghosalya ghosalya merged commit 92358d3 into master Nov 10, 2020
@ghosalya ghosalya deleted the cOeutIqt/1028-fix-discreetly branch November 10, 2020 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghosalya ghosalya ghosalya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@minhducvt293 @ghosalya