Pass file_lock as positional argument
#347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwist-sgr
changed the title
file_lock as positional argument
gaborbernat
approved these changes
Jun 22, 2024
github-merge-queue bot
referenced
this pull request
in rustymotors/server
Jun 22, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [filelock](https://github.com/tox-dev/py-filelock) | `==3.15.3` -> `==3.15.4` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>tox-dev/py-filelock (filelock)</summary> ### [`v3.15.4`](https://github.com/tox-dev/filelock/releases/tag/3.15.4) [Compare Source](https://github.com/tox-dev/py-filelock/compare/3.15.3...3.15.4) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed - Pass `file_lock` as positional argument by [@​kwist-sgr](https://github.com/kwist-sgr) in [https://github.com/tox-dev/filelock/pull/347](https://github.com/tox-dev/filelock/pull/347) **Full Changelog**: tox-dev/filelock@3.15.3...3.15.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/rustymotors/server). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjQxMy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
github-merge-queue bot
referenced
this pull request
in rustymotors/server
Jun 29, 2024
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [filelock](https://github.com/tox-dev/py-filelock) | `==3.15.3` -> `==3.15.4` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>tox-dev/py-filelock (filelock)</summary> ### [`v3.15.4`](https://github.com/tox-dev/filelock/releases/tag/3.15.4) [Compare Source](https://github.com/tox-dev/py-filelock/compare/3.15.3...3.15.4) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed - Pass `file_lock` as positional argument by [@​kwist-sgr](https://github.com/kwist-sgr) in [https://github.com/tox-dev/filelock/pull/347](https://github.com/tox-dev/filelock/pull/347) **Full Changelog**: tox-dev/filelock@3.15.3...3.15.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled because a matching PR was automerged previously. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/rustymotors/server). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MTMuMiIsInVwZGF0ZWRJblZlciI6IjM3LjQxMy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
github-merge-queue bot
referenced
this pull request
in rustymotors/server
Jun 30, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [filelock](https://github.com/tox-dev/py-filelock) | `==3.15.3` -> `==3.15.4` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>tox-dev/py-filelock (filelock)</summary> ### [`v3.15.4`](https://github.com/tox-dev/filelock/releases/tag/3.15.4) [Compare Source](https://github.com/tox-dev/py-filelock/compare/3.15.3...3.15.4) <!-- Release notes generated using configuration in .github/release.yml at main --> #### What's Changed - Pass `file_lock` as positional argument by [@​kwist-sgr](https://github.com/kwist-sgr) in [https://github.com/tox-dev/filelock/pull/347](https://github.com/tox-dev/filelock/pull/347) **Full Changelog**: tox-dev/filelock@3.15.3...3.15.4 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled because a matching PR was automerged previously. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/rustymotors/server). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->
1 task
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason
Make it possible to pass
file_lockunder a different name in the signature of the__init__method of descendant classesfixes tox-dev/filelock/issues/346
Related PRs
TypeError: _CountedFileLock.__init__() got an unexpected keyword argument 'timeout'#345