Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: make BoxService impl Sync via SyncWrapper #702

Merged
merged 4 commits into from
Nov 27, 2022
Merged

util: make BoxService impl Sync via SyncWrapper #702

merged 4 commits into from
Nov 27, 2022

Conversation

davidpdrsn
Copy link
Member

Fixes #697

@davidpdrsn davidpdrsn added the A-util Area: The tower "util" module label Oct 13, 2022
@LucioFranco LucioFranco requested review from hawkw, seanmonstar and a team October 21, 2022 15:19
LucioFranco
LucioFranco approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the surface this seems fine to me but I'd like others to also take a look.

@mre
Copy link

mre commented Nov 26, 2022

Are there any blockers before this can be merged? I'm asking because this would be helpful for lychee (lycheeverse/lychee#826).

@davidpdrsn davidpdrsn enabled auto-merge (squash) November 27, 2022 10:04
@davidpdrsn
Copy link
Member Author

Think I'll just merge it. Its pretty low risk.

@davidpdrsn davidpdrsn merged commit c34182d into master Nov 27, 2022
@davidpdrsn davidpdrsn deleted the david/box-service-sync branch November 27, 2022 10:09
@banool banool mentioned this pull request Mar 19, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucioFranco LucioFranco LucioFranco approved these changes

@hawkw hawkw Awaiting requested review from hawkw

@seanmonstar seanmonstar Awaiting requested review from seanmonstar

Assignees
No one assigned
Labels
A-util Area: The tower "util" module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BoxService is unnecessarily !Sync
3 participants
@davidpdrsn @mre @LucioFranco