Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tower: prepare to release 0.4.11 #618

Merged
merged 5 commits into from
Nov 18, 2021
Merged

tower: prepare to release 0.4.11 #618

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
75ead74
tower: prepare to release 0.4.11
davidpdrsn Nov 18, 2021
42b4d7f
sorting
davidpdrsn Nov 18, 2021
dc246b1
Rename `CloneBoxService` to `BoxCloneService`
davidpdrsn Nov 18, 2021
87ea3e1
formatting
davidpdrsn Nov 18, 2021
623f983
also update changelog
davidpdrsn Nov 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 17 additions & 9 deletions tower/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,16 +7,23 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

# Unreleased

- **util**: Add `CloneBoxService` which is a `Clone + Send` boxed `Service`.
- **util:** Add `ServiceExt::boxed` and `ServiceExt::clone_boxed` for applying the
`BoxService` and `CloneBoxService` middleware.
- **builder:** Add `ServiceBuilder::boxed` and `ServiceBuilder::clone_boxed` for
applying `BoxService` and `CloneBoxService` layers.
- **util**: Remove unnecessary `Debug` bounds from `impl Debug for BoxService`.
- **util**: Remove unnecessary `Debug` bounds from `impl Debug for UnsyncBoxService`.
- None.

# 0.4.11 (November 18, 2021)

### Added

- **util**: Add `CloneBoxService` which is a `Clone + Send` boxed `Service` ([#615])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **util**: Add `CloneBoxService` which is a `Clone + Send` boxed `Service` ([#615])
- **util**: Add `BoxCloneService` which is a `Clone + Send` boxed `Service` ([#615])

- **util**: Add `ServiceExt::boxed` and `ServiceExt::clone_boxed` for applying the
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **util**: Add `ServiceExt::boxed` and `ServiceExt::clone_boxed` for applying the
- **util**: Add `ServiceExt::boxed` and `ServiceExt::boxed_clone` for applying the

`BoxService` and `CloneBoxService` middleware ([#616])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`BoxService` and `CloneBoxService` middleware ([#616])
`BoxService` and `BoxCloneService` middleware ([#616])

- **builder**: Add `ServiceBuilder::boxed` and `ServiceBuilder::clone_boxed` for
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- **builder**: Add `ServiceBuilder::boxed` and `ServiceBuilder::clone_boxed` for
- **builder**: Add `ServiceBuilder::boxed` and `ServiceBuilder::boxed_clone` for

applying `BoxService` and `CloneBoxService` layers ([#616])
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know I should have spotted this in #616, but let me revive the naming question before a release goes out... I think think should be called BoxCloneService (and helper should be boxed_clone). My reasoning is that this makes the type/method names lexically grouped (i.e in documentation or tab completion). When searching I'll see all the Box*Services together.

We can defer this to 0.5, though, I guess, since CloneBoxService is similar to UnsyncBoxService...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hawkw wondered about that too. I don't feel strongly about it, so think I'll just rename it in this PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the change notes need to be updated as well, now...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
applying `BoxService` and `CloneBoxService` layers ([#616])
applying `BoxService` and `BoxCloneService` layers ([#616])

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops! Was a bit too quick with the search and replace. Fixed it!


### Fixed

- **util**: Remove redundant `F: Clone` bound from `ServiceExt::map_request` ([#607])
- **util**: Remove unnecessary `Debug` bounds from `impl Debug for BoxService` ([#617])
- **util**: Remove unnecessary `Debug` bounds from `impl Debug for UnsyncBoxService` ([#617])
- **balance**: Remove redundant `Req: Clone` bound from `Clone` impls
for `MakeBalance`, and `MakeBalanceLayer` ([#607])
- **balance**: Remove redundant `Req: Debug` bound from `Debug` impls
Expand All @@ -25,13 +32,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
for `ReadyCache` ([#607])
- **steer**: Remove redundant `Req: Debug` bound from `Debug` impl
for `Steer` ([#607])
- **util**: Remove redundant `F: Clone` bound
from `ServiceExt::map_request` ([#607])
- **docs**: Fix `doc(cfg(...))` attributes
of `PeakEwmaDiscover`, and `PendingRequestsDiscover` ([#610])

[#607]: https://github.com/tower-rs/tower/pull/607
[#610]: https://github.com/tower-rs/tower/pull/610
[#616]: https://github.com/tower-rs/tower/pull/616
[#617]: https://github.com/tower-rs/tower/pull/617
[#615]: https://github.com/tower-rs/tower/pull/615

# 0.4.10 (October 19, 2021)

Expand Down
4 changes: 2 additions & 2 deletions tower/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,13 @@ name = "tower"
# - README.md
# - Update CHANGELOG.md.
# - Create "vX.X.X" git tag.
version = "0.4.10"
version = "0.4.11"
authors = ["Tower Maintainers <team@tower-rs.com>"]
license = "MIT"
readme = "README.md"
repository = "https://github.com/tower-rs/tower"
homepage = "https://github.com/tower-rs/tower"
documentation = "https://docs.rs/tower/0.4.10"
documentation = "https://docs.rs/tower/0.4.11"
description = """
Tower is a library of modular and reusable components for building robust
clients and servers.
Expand Down
2 changes: 1 addition & 1 deletion tower/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#![doc(html_root_url = "https://docs.rs/tower/0.4.10")]
#![doc(html_root_url = "https://docs.rs/tower/0.4.11")]
#![warn(
missing_debug_implementations,
missing_docs,
Expand Down