Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pooling #229

Merged
merged 10 commits into from
Nov 8, 2019
Merged

Pooling #229

merged 10 commits into from
Nov 8, 2019

Conversation

AEnterprise
Copy link
Collaborator

@AEnterprise AEnterprise commented Oct 30, 2019

working on pooling, not done yet

Description

will give more details later on the implementation but basically just uses a pool instead of a direct connection

Motivation and Context

should significantly boost performance

How Has This Been Tested?

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@coveralls
Copy link

coveralls commented Nov 6, 2019

Pull Request Test Coverage Report for Build 983

  • 85 of 92 (92.39%) changed or added relevant lines in 5 files are covered.
  • 22 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.8%) to 96.612%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tortoise/backends/mysql/client.py 24 27 88.89%
tortoise/backends/asyncpg/client.py 20 24 83.33%
Files with Coverage Reduction New Missed Lines %
tortoise/transactions.py 5 80.0%
tortoise/backends/mysql/client.py 8 90.4%
tortoise/backends/asyncpg/client.py 9 88.95%
Totals Coverage Status
Change from base Build 969: -0.8%
Covered Lines: 6094
Relevant Lines: 6242

💛 - Coveralls

@grigi
Copy link
Member

grigi commented Nov 6, 2019

Woohoo! This is looking very good! 🎉 So close...

It's probably ready for you to use it with your own project and see if it resolves the QoS issues?

I wondered why the code coverage seems to have dropped so much, but looking at the report on Travis... Something weird, because basic code like doing inserts with SQLite has no coverage... 😕

@grigi
Copy link
Member

grigi commented Nov 6, 2019

Right, other than the nested transaction test, you need to add a changelog. Make the version 0.15.0 and have a nice short blurb about how to use this, and what it provides you.

@grigi
Copy link
Member

grigi commented Nov 8, 2019

Thank you!, this looks great. 👍
I'm planning to do some more bugfixes and release 0.14.x for a little while, so I can ensure that this is working as intended.

@grigi grigi merged commit bd9f4ea into tortoise:develop Nov 8, 2019
@AEnterprise
Copy link
Collaborator Author

i hope it works great, i assume those fixes will also be on this branch? i can then use this branch in the dev version of my project for a while to test it even more to make sure it doesn't break

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants