Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MP-945] Add controlled Section behavior support #4678

Merged
merged 4 commits into from
Feb 24, 2025

Conversation

sashuk
Copy link
Contributor

@sashuk sashuk commented Feb 24, 2025

MP-945

Description

Make Section component controlled.

⚠️ There is height glitch, but it happens in master and will be addressed separately.

How to test

  • Temploy
  • Check the Controlled component story

Screenshots

Kapture.2025-02-24.at.16.11.43.mp4

Development checks

  • Add changeset according to guidelines (if needed)
  • Double check if picasso-tailwind-merge requires major update (check its README.md)
  • Read CONTRIBUTING.md and Component API principles
  • Make sure that additions and changes on the design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
  • Annotate all props in component with documentation
  • Create examples for component
  • Ensure that deployed demo has expected results and good examples
  • Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
  • Self reviewed
  • Covered with tests (visual tests included)

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping for reviews
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@sashuk sashuk self-assigned this Feb 24, 2025
Copy link

changeset-bot bot commented Feb 24, 2025

🦋 Changeset detected

Latest commit: 1946527

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@toptal/picasso-section Minor
@toptal/picasso Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sashuk sashuk marked this pull request as ready for review February 24, 2025 16:15
@sashuk sashuk requested a review from a team as a code owner February 24, 2025 16:15
@sashuk
Copy link
Contributor Author

sashuk commented Feb 24, 2025

@toptal-anvil ping reviewers

@sashuk sashuk changed the title [MP-945] Make Section component controlled [MP-945] Add controlled Section behavior support Feb 24, 2025
@sashuk sashuk requested review from a team and denieler February 24, 2025 17:01
@sashuk sashuk merged commit 41dce38 into master Feb 24, 2025
18 checks passed
@sashuk sashuk deleted the MP-915-make-section-controlled branch February 24, 2025 17:23
@toptal-build toptal-build mentioned this pull request Feb 24, 2025
1 task
@sashuk sashuk mentioned this pull request Feb 24, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants