les: fix dead lock (ethereum#20828)

tony-ricciardi · Nov 18, 2020 · 19bf7b8 · 19bf7b8
1 parent 32a6af1
commit 19bf7b8
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/les/peer.go b/les/peer.go
@@ -611,8 +611,6 @@ func (p *serverPeer) getTxRelayCost(amount, size int) uint64 {
 // HasBlock checks if the peer has a given block
 func (p *serverPeer) HasBlock(hash common.Hash, number *uint64, hasState bool) bool {
 	p.lock.RLock()
-	defer p.lock.RUnlock()
-
 	head := p.headInfo.Number
 	var since, recent uint64
 	if hasState {
@@ -623,6 +621,7 @@ func (p *serverPeer) HasBlock(hash common.Hash, number *uint64, hasState bool) b
 		recent = p.chainRecent
 	}
 	hasBlock := p.hasBlock
+	p.lock.RUnlock()
 
 	// If number is not provided then we return an optimistic yet possible false positive
 	if number == nil {