Handling parsing of multiple scopes combined in a single string.

It is possible for challenge headers to contain multiple scopes in a single string. This change ensures that this case is handled when parsing the scopes by splitting out scopes combined in a single string.

Signed-off-by: Jacob MacElroy <jacob@okteto.com>

util/resolver/authorizer.go

@@ -434,25 +434,28 @@ type scopes map[string]map[string]struct{}
 func parseScopes(s []string) scopes {
 	// https://docs.docker.com/registry/spec/auth/scope/
 	m := map[string]map[string]struct{}{}
-	for _, scope := range s {
-		parts := strings.SplitN(scope, ":", 3)
-		names := []string{parts[0]}
-		if len(parts) > 1 {
-			names = append(names, parts[1])
-		}
-		var actions []string
-		if len(parts) == 3 {
-			actions = append(actions, strings.Split(parts[2], ",")...)
-		}
-		name := strings.Join(names, ":")
-		ma, ok := m[name]
-		if !ok {
-			ma = map[string]struct{}{}
-			m[name] = ma
-		}
+	for _, scopeStr := range s {
+		// The scopeStr may have strings that contain multiple scopes separated by a space.
+		for _, scope := range strings.Split(scopeStr, " ") {
+			parts := strings.SplitN(scope, ":", 3)
+			names := []string{parts[0]}
+			if len(parts) > 1 {
+				names = append(names, parts[1])
+			}
+			var actions []string
+			if len(parts) == 3 {
+				actions = append(actions, strings.Split(parts[2], ",")...)
+			}
+			name := strings.Join(names, ":")
+			ma, ok := m[name]
+			if !ok {
+				ma = map[string]struct{}{}
+				m[name] = ma
+			}
 
-		for _, a := range actions {
-			ma[a] = struct{}{}
+			for _, a := range actions {
+				ma[a] = struct{}{}
+			}
 		}
 	}
 	return m

util/resolver/authorizer_test.go

@@ -0,0 +1,51 @@
+package resolver
+
+import (
+	"reflect"
+	"testing"
+)
+
+func TestParseScopes(t *testing.T) {
+	for _, tc := range []struct {
+		name     string
+		input    []string
+		expected scopes
+	}{
+		{
+			name: "SeparateStrings",
+			input: []string{
+				"repository:foo/bar:pull",
+				"repository:foo/baz:pull,push",
+			},
+			expected: map[string]map[string]struct{}{
+				"repository:foo/bar": {
+					"pull": struct{}{},
+				},
+				"repository:foo/baz": {
+					"pull": struct{}{},
+					"push": struct{}{},
+				},
+			},
+		},
+		{
+			name:  "CombinedStrings",
+			input: []string{"repository:foo/bar:pull repository:foo/baz:pull,push"},
+			expected: map[string]map[string]struct{}{
+				"repository:foo/bar": {
+					"pull": struct{}{},
+				},
+				"repository:foo/baz": {
+					"pull": struct{}{},
+					"push": struct{}{},
+				},
+			},
+		},
+	} {
+		t.Run(tc.name, func(t *testing.T) {
+			parsed := parseScopes(tc.input)
+			if !reflect.DeepEqual(parsed, tc.expected) {
+				t.Fatalf("expected %v, got %v", tc.expected, parsed)
+			}
+		})
+	}
+}