Gsi projection and ttl fix #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from original repo
…global_secondary_index
Ttl attribute support
PLM-1398 Added support for projection_type and non_key_attributes in …
Ttl attribute support
added TTL to readme
PLM-1398 fix(main.tf): conditionally assign non_key_attributes in Dyn…
Gsi projection and ttl
evgenygigi
requested review from
raanan245,
Eli-Meitner,
srinivas-toluna and
waseemkh88
Eli-Meitner
approved these changes
Jan 29, 2024
waseemkh88
reviewed
Jan 29, 2024
| } | ||
|
|
||
| dynamic "ttl" { | ||
| for_each = var.ttl_attribute_name != null ? [1] : [] |
There was a problem hiding this comment.
Hi @evgenygigi , the ttl_attribute_name is string and not a list, and I am confused with the foreach loop that you are having here. Can you please explain?
There was a problem hiding this comment.
Because of how dynamic block works https://developer.hashicorp.com/terraform/language/expressions/dynamic-blocks
If var.ttl_attribute_name is not null (meaning it has a value), the for_each expression evaluates to [1], creating a single iteration of the block.
If var.ttl_attribute_name is null, the expression evaluates to an empty list ([]), effectively skipping the block's execution.
the [1] indicates the number of iterations.
waseemkh88
approved these changes
Jan 29, 2024
raanan245
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of #14
In this PR we implementing the TTL a bit different due to the know bug/feature of AWS.
When you passing
ttl_attribute_nameattribute the TTL will be enabled on your dynamodb table otherwise it will not be crated at all.