macros: fix breakage in experimental tracing-macros crate
#882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `tracing-macros` crate uses internal `tracing` APIs that are unstable. These APIs changed in 0.1.18 (not a breaking change, since they are explicitly not stable API). `tracing-macros` needed to be updated to use the new versions of the internal APIs. As a side note, I'm surprised this wasn't caught before merging the branch, and only happened on `master`. Are we not checking all crates for PR builds? If so, we should probably fix that. Signed-off-by: Eliza Weisman <eliza@buoyant.io>
LucioFranco
approved these changes
Aug 3, 2020
This was referenced Aug 3, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
tracing-macroscrate uses internaltracingAPIs that areunstable. These APIs changed in 0.1.18 (not a breaking change, since
they are explicitly not stable API).
tracing-macrosneeded to beupdated to use the new versions of the internal APIs.
As a side note, I'm surprised this wasn't caught before merging the
branch, and only happened on
master. Are we not checking all cratesfor PR builds? If so, we should probably fix that.
Signed-off-by: Eliza Weisman eliza@buoyant.io