chore: prepare tracing-subscriber 0.3.19 #3162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
davidbarsky
approved these changes
Nov 29, 2024
# 0.3.19 (November 29, 2024) [ [crates.io][crate-0.3.19] ] | [ [docs.rs][docs-0.3.19] ] This release updates the `tracing` dependency to [v0.1.41][tracing-0.1.41] and the `tracing-serde` dependency to [v0.2.0][tracing-serde-0.2.0]. ### Added - Add `set_span_events` to `fmt::Subscriber` ([#2962]) - **tracing**: Allow `&[u8]` to be recorded as event/span field ([#2954]) ### Changed - Set `log` max level when reloading ([#1270]) - Bump MSRV to 1.63 ([#2793]) - Use const `thread_local`s when possible ([#2838]) - Don't gate `with_ansi()` on the "ansi" feature ([#3020]) - Updated tracing-serde to 0.2.0 ([#3160]) [#1270]: #1270 [#2793]: #2793 [#2838]: #2838 [#2954]: #2954 [#2962]: #2962 [#3020]: #3020 [#3160]: #3160 [tracing-0.1.41]: https://github.com/tokio-rs/tracing/releases/tag/tracing-0.1.41 [tracing-serde-0.2.0]: https://github.com/tokio-rs/tracing/releases/tag/tracing-serde-0.2.0 [docs-0.3.19]: https://docs.rs/tracing-subscriber/0.3.19/tracing_subscriber/ [crate-0.3.19]: https://crates.io/crates/tracing-subscriber/0.3.19
hds
force-pushed
the
hds/tracing-subscriber-0.3.19
branch
from
24bcf71 to
2393d67
Compare
hds
added a commit
that referenced
this pull request
Jan 24, 2025
The change #2954 was released in 0.3.19 (#3162). Notably, it relied on features from tracing-core 0.1.33, however, the version was never bumped. Users of the `tracing` feature of `tracing-subscriber` would have no issue since it pulls in the higher version transitively. The specific feature used was implementing trait method `record_bytes` from the `field::Visit` trait on `JsonVisitor` from the tracing-subscriber json format module. (see linked #2945, or [ `impl field::Visit for JsonVisitor<'_>`](https://github.com/tokio-rs/tracing/blame/master/tracing-subscriber/src/fmt/format/json.rs#L491)) I believe this dependency mismatch requires users to manually select the higher tracing-core version or suffer compilation failure. This probably reflects some failure in how the tests utilize features and intra-workspace dependencies, but, a resolution for that is beyond my current comprehension of the project.
davidbarsky
pushed a commit
that referenced
this pull request
Jan 27, 2025
The change #2954 was released in 0.3.19 (#3162). Notably, it relied on features from tracing-core 0.1.33, however, the version was never bumped. Users of the `tracing` feature of `tracing-subscriber` would have no issue since it pulls in the higher version transitively. The specific feature used was implementing trait method `record_bytes` from the `field::Visit` trait on `JsonVisitor` from the tracing-subscriber json format module. (see linked #2945, or [ `impl field::Visit for JsonVisitor<'_>`](https://github.com/tokio-rs/tracing/blame/master/tracing-subscriber/src/fmt/format/json.rs#L491)) I believe this dependency mismatch requires users to manually select the higher tracing-core version or suffer compilation failure. This probably reflects some failure in how the tests utilize features and intra-workspace dependencies, but, a resolution for that is beyond my current comprehension of the project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.3.19 (November 29, 2024)
[ crates.io ] | [ docs.rs ]
This release updates the
tracingdependency to v0.1.41 andthe
tracing-serdedependency to v0.2.0.Added
set_span_eventstofmt::Subscriber(#2962)&[u8]to be recorded as event/span field (#2954)Changed
logmax level when reloading (#1270)thread_locals when possible (#2838)with_ansi()on the "ansi" feature (#3020)