Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context docs in tracing-subscriber reference scope method that does not exist #2890

Closed
taladar opened this issue Feb 22, 2024 · 0 comments · Fixed by #2894
Closed

Context docs in tracing-subscriber reference scope method that does not exist #2890

taladar opened this issue Feb 22, 2024 · 0 comments · Fixed by #2894

Comments

@taladar
Copy link

taladar commented Feb 22, 2024

In

https://docs.rs/tracing-subscriber/latest/tracing_subscriber/layer/struct.Context.html

there are some notes about the ordering of returned scopes by a scope method that does not seem to exist.
kaffarell added a commit to kaffarell/tracing that referenced this issue Feb 29, 2024
@kaffarell
docs: remove non-existing method in comments
eff41fe 
In the documentation of the layer context span_scope method, the note
contained a reference to a `scope()` method, which was removed some time
ago. Also fixed a phrasing error above.

Fixes: tokio-rs#2890
@kaffarell kaffarell mentioned this issue Feb 29, 2024
Merged
kaffarell added a commit to kaffarell/tracing that referenced this issue Mar 4, 2024
@kaffarell
docs: remove non-existing method in comments
6187b00 
In the documentation of the layer context span_scope method, the note
contained a reference to a `scope()` method, which was removed some time
ago. Also fixed a phrasing error above.

Fixes: tokio-rs#2890
davidbarsky pushed a commit that referenced this issue May 25, 2024
@kaffarell
docs: remove non-existing method in comments (#2894)
382ee01 
In the documentation of the layer context span_scope method, the note
contained a reference to a `scope()` method, which was removed some time
ago. Also fixed a phrasing error above.

Fixes: #2890
hds pushed a commit that referenced this issue Nov 21, 2024
@kaffarell @hds
docs: remove non-existing method in comments (#2894)
59a48c7 
In the documentation of the layer context span_scope method, the note
contained a reference to a `scope()` method, which was removed some time
ago. Also fixed a phrasing error above.

Fixes: #2890
hds pushed a commit that referenced this issue Nov 22, 2024
@kaffarell @hds
docs: remove non-existing method in comments (#2894)
329d8d3 
In the documentation of the layer context span_scope method, the note
contained a reference to a `scope()` method, which was removed some time
ago. Also fixed a phrasing error above.

Fixes: #2890
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: subscriber context docs kaffarell/tracing
1 participant
@taladar