Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tokio-threadpool example to use tokio-timer 0.2 #764

Closed
carllerche opened this issue Nov 20, 2018 · 3 comments · Fixed by #770
Closed

Update tokio-threadpool example to use tokio-timer 0.2 #764

carllerche opened this issue Nov 20, 2018 · 3 comments · Fixed by #770
Labels
A-tokio Area: The main tokio crate M-runtime Module: tokio/runtime M-time Module: tokio/time T-docs Topic: documentation

Comments

@carllerche
Copy link
Member

This example uses tokio-timer 0.1. This is an old dependency.

The example should be updated to use the latest release of tokio-timer.

@carllerche carllerche added the C-maintenance Category: PRs that clean code up or issues documenting cleanup. label Nov 20, 2018
@flxo
Copy link
Contributor

flxo commented Nov 20, 2018

I attempted to fix this in here. When I run the example I don't see the interval stream processed. What am I missing with the timer?

@carllerche
Copy link
Member Author

Thanks for taking a stab at this.

The issue is that the timer in 0.2 doesn't spawn a background thread by default, so you are responsible for "ticking" the timer handle.

Looking at the file more closely, I don't think it is very useful anymore. I would probably just delete smoke.rs and remove the old timer dep and call it a day.

Thanks 👍

@flxo
Copy link
Contributor

flxo commented Nov 21, 2018

Ok. No problem. I will create a PR.

@Darksonn Darksonn added A-tokio Area: The main tokio crate M-runtime Module: tokio/runtime M-time Module: tokio/time T-docs Topic: documentation and removed C-maintenance Category: PRs that clean code up or issues documenting cleanup. labels Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate M-runtime Module: tokio/runtime M-time Module: tokio/time T-docs Topic: documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants