refactor(blocks): simplify frame manager implementation #8507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
|
Your org has enabled the Graphite merge queue for merging into masterAdd the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit c427926. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
doodlewind
approved these changes
Oct 12, 2024
L-Sun
force-pushed
the
l-sun/refactor/element-tree
branch
from
7433fda to
80a2b6d
Compare
L-Sun
force-pushed
the
l-sun/refactor/frame-manager
branch
from
2543d1b to
1781988
Compare
Merge activity
|
This PR removes redundant code related to the container-child element relationship, which is now maintained by the new `TreeManager` after #8239 .
L-Sun
force-pushed
the
l-sun/refactor/element-tree
branch
from
80a2b6d to
1e7573e
Compare
L-Sun
force-pushed
the
l-sun/refactor/frame-manager
branch
from
1781988 to
c427926
Compare
donteatfriedrice
added a commit
that referenced
this pull request
Oct 16, 2024
## Features: [feat: markdown adapter with latex](#8503) [feat: support notion block equation html import](#8504) [feat: support edgeless tidy up](#8516) [feat: support notion callout block to blocksuite quote block](#8523) [feat(playground): add import notion zip entry](#8527) ## Bugfix: [fix(blocks): auto focus latex block](#8505) [fix: enhance button layout with icon alignment](#8508) [fix(edgeless): ime will crash edgeless text width](#8506) [fix(edgeless): edgeless text is deleted when first block is empty](#8512) [fix: notion html quote block import](#8515) [fix: yjs warning](#8519) [fix(blocks): real nested list on html export](#8511) [fix(edgeless): cmd a will select element inner frame](#8517) [fix(edgeless): disable contenteditable when edgeless text not in editing state](#8525) [fix: import notion toggle list as toggle bulleted list](#8528) ## Refactor: [refactor(database): signals version datasource api](#8513) [refactor(edgeless): element tree manager](#8239) [refactor(blocks): simplify frame manager implementation](#8507) [refactor: update group test utils using container interface](#8518) [refactor: update frame test with container test uitls](#8520) [refactor(database): context-menu ui and ux](#8467) [refactor: move chat block to affine](#8420) ## Misc [perf: optimize snapshot job handling](#8428) [perf(edgeless): disable shape shadow blur](#8532) [chore: bump up all non-major dependencies](#8514) [chore: Lock file maintenance](#8510) ## Docs [docs: fix table structure warning](#8509) [docs: edgeless data structure desc](#8531) [docs: update link](#8533)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes redundant code related to the container-child element relationship, which is now maintained by the new
TreeManagerafter #8239 .