Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(std): dispatcher pointerUp calls twice #8485

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

majula2111
Copy link
Contributor

When subscribing to pointerUp it is patched 2 times due to a duplicate in ClickController

@majula2111 majula2111 requested a review from a team as a code owner October 2, 2024 06:39
Copy link

changeset-bot bot commented Oct 2, 2024

⚠️ No Changeset found

Latest commit: bedef7d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blocksuite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2024 6:40am

Copy link

graphite-app bot commented Oct 2, 2024

Your org has enabled the Graphite merge queue for merging into master

Add the label “merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

vercel bot commented Oct 2, 2024

Someone is attempting to deploy a commit to the toeverything Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

nx-cloud bot commented Oct 2, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit bedef7d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@majula2111 majula2111 changed the title fix(block-std): dispatcher pointerUp calls twice fix(std): dispatcher pointerUp calls twice Oct 2, 2024
Copy link
Contributor

@L-Sun L-Sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@L-Sun L-Sun added the merge label Oct 4, 2024
Copy link

graphite-app bot commented Oct 4, 2024

Merge activity

  • Oct 4, 12:41 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 4, 12:41 PM EDT: L-Sun added this pull request to the Graphite merge queue.
  • Oct 4, 12:41 PM EDT: The Graphite merge queue couldn't merge this PR because it failed for an unknown reason (Stack merges are not currently supported for forked repositories. Please create a branch in the target repository in order to merge).
  • Oct 4, 12:43 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 4, 12:43 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 4, 12:43 PM EDT: L-Sun added this pull request to the Graphite merge queue.
  • Oct 4, 4:44 PM UTC: graphite-app removed this pull request from the Graphite merge queue.
  • Oct 4, 4:44 PM UTC: The merge label 'merge' was removed. This PR will no longer be merged by the Graphite merge queue
  • Oct 4, 12:44 PM EDT: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Oct 4, 12:44 PM EDT: The Graphite merge queue couldn't merge this PR because it failed for an unknown reason (Stack merges are not currently supported for forked repositories. Please create a branch in the target repository in order to merge).

@graphite-app graphite-app bot removed the merge label Oct 4, 2024
@L-Sun L-Sun added the merge label Oct 4, 2024 — with Graphite App
@graphite-app graphite-app bot removed the merge label Oct 4, 2024
@L-Sun L-Sun added the merge label Oct 4, 2024 — with Graphite App
@graphite-app graphite-app bot removed the merge label Oct 4, 2024
@L-Sun L-Sun merged commit b9d7ac6 into toeverything:master Oct 4, 2024
35 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants