Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): optimize team workspace member management #9737

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

JimmFly
Copy link
Member

@JimmFly JimmFly commented Jan 16, 2025

close AF-2106 AF-2077 AF-2089

feat(core): handle need more seat status

feat(core): prevent invite members when team plan is canceled

Copy link
Member Author

JimmFly commented Jan 16, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@JimmFly JimmFly changed the title feat(core): handle need more seat status feat(core): optimize team workspace member management Jan 16, 2025
@JimmFly JimmFly marked this pull request as ready for review January 16, 2025 11:59
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Project coverage is 53.74%. Comparing base (85d916f) to head (d5a626d).
Report is 2 commits behind head on canary.

Files with missing lines Patch % Lines
...d/core/src/modules/cloud/services/accept-invite.ts 0.00% 15 Missing ⚠️
...ntend/core/src/modules/cloud/stores/invite-info.ts 0.00% 5 Missing ⚠️
...end/core/src/modules/cloud/stores/accept-invite.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9737      +/-   ##
==========================================
- Coverage   53.77%   53.74%   -0.03%     
==========================================
  Files        2272     2275       +3     
  Lines      104413   104436      +23     
  Branches    17289    17293       +4     
==========================================
- Hits        56144    56128      -16     
- Misses      46905    46944      +39     
  Partials     1364     1364              
Flag Coverage Δ
server-test 77.84% <ø> (-0.05%) ⬇️
unittest 31.82% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JimmFly JimmFly force-pushed the jimmfly/0116/team-need-more-seat branch from 7758c10 to d449b09 Compare January 24, 2025 03:51
@JimmFly JimmFly force-pushed the jimmfly/0116/team-need-more-seat branch from d449b09 to 1d6ac3d Compare February 3, 2025 15:54
@JimmFly JimmFly requested a review from EYHN February 3, 2025 15:55
@JimmFly JimmFly force-pushed the jimmfly/0116/team-need-more-seat branch 4 times, most recently from df7e55c to 5b4f3d7 Compare February 7, 2025 05:12
@EYHN EYHN self-requested a review February 7, 2025 06:41
close AF-2106 AF-2077 AF-2089

feat(core): handle need more seat status

feat(core): prevent invite members when team plan is canceled
@graphite-app graphite-app bot force-pushed the jimmfly/0116/team-need-more-seat branch from f6530ae to d5a626d Compare February 7, 2025 10:08
Copy link

graphite-app bot commented Feb 7, 2025

Merge activity

@graphite-app graphite-app bot merged commit d5a626d into canary Feb 7, 2025
64 checks passed
@graphite-app graphite-app bot deleted the jimmfly/0116/team-need-more-seat branch February 7, 2025 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants