Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): move block collection to affine and implement as doc #9514

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

Saul-Mirone
Copy link
Contributor

No description provided.

Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Saul-Mirone Saul-Mirone changed the title refactor(core): implement doc refactor(core): move block collection to affine and implement as doc Jan 3, 2025
@Saul-Mirone Saul-Mirone marked this pull request as ready for review January 3, 2025 16:10
@Saul-Mirone Saul-Mirone requested a review from a team as a code owner January 3, 2025 16:10
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 5.09554% with 149 lines in your changes missing coverage. Please review.

Project coverage is 53.02%. Comparing base (4cb186d) to head (dcf4993).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...es/frontend/core/src/modules/workspace/impl/doc.ts 0.00% 136 Missing ⚠️
...ntend/core/src/modules/workspace/impl/workspace.ts 0.00% 3 Missing ⚠️
blocksuite/framework/store/src/test/test-doc.ts 60.00% 2 Missing ⚠️
...ocksuite/affine/block-data-view/src/data-source.ts 0.00% 1 Missing ⚠️
...uite/affine/block-data-view/src/data-view-model.ts 0.00% 1 Missing ⚠️
...ite/affine/block-database/src/utils/block-utils.ts 50.00% 1 Missing ⚠️
...c/embed-linked-doc-block/embed-linked-doc-block.ts 0.00% 1 Missing ⚠️
...c/embed-synced-doc-block/embed-synced-doc-block.ts 0.00% 1 Missing ⚠️
...e/block-paragraph/src/commands/append-paragraph.ts 0.00% 1 Missing ⚠️
...k/widgets/embed-card-toolbar/embed-card-toolbar.ts 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9514      +/-   ##
==========================================
+ Coverage   52.87%   53.02%   +0.14%     
==========================================
  Files        2151     2152       +1     
  Lines       96989    97119     +130     
  Branches    16154    16208      +54     
==========================================
+ Hits        51284    51493     +209     
+ Misses      44343    44228     -115     
- Partials     1362     1398      +36     
Flag Coverage Δ
server-test 78.79% <ø> (+0.64%) ⬆️
unittest 32.37% <4.45%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Saul-Mirone Saul-Mirone force-pushed the 01-04-refactor_core_implement_doc branch 2 times, most recently from 5cb5a19 to 0a3b3c0 Compare January 4, 2025 04:09
@github-actions github-actions bot added the test Related to test cases label Jan 4, 2025
@Saul-Mirone Saul-Mirone force-pushed the 01-04-refactor_core_implement_doc branch 4 times, most recently from 2ff2712 to 5f53af7 Compare January 4, 2025 05:58
Copy link

graphite-app bot commented Jan 4, 2025

Merge activity

@Saul-Mirone Saul-Mirone force-pushed the 01-04-refactor_core_implement_doc branch from 5f53af7 to dcf4993 Compare January 4, 2025 06:28
@graphite-app graphite-app bot merged commit dcf4993 into canary Jan 4, 2025
61 checks passed
@graphite-app graphite-app bot deleted the 01-04-refactor_core_implement_doc branch January 4, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants