Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): client version check #9205

Merged
merged 1 commit into from
Feb 20, 2025
Merged

feat(server): client version check #9205

merged 1 commit into from
Feb 20, 2025

Conversation

darkskygit
Copy link
Member

No description provided.

@github-actions github-actions bot added app:server test Related to test cases labels Dec 19, 2024
Copy link
Member Author

darkskygit commented Dec 19, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 97.31183% with 5 lines in your changes missing coverage. Please review.

Project coverage is 54.20%. Comparing base (d490e76) to head (a7269ef).
Report is 8 commits behind head on canary.

Files with missing lines Patch % Lines
...ackages/backend/server/src/core/version/service.ts 93.22% 3 Missing and 1 partial ⚠️
packages/backend/server/src/core/version/guard.ts 97.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #9205      +/-   ##
==========================================
+ Coverage   54.11%   54.20%   +0.08%     
==========================================
  Files        2335     2339       +4     
  Lines      107821   108040     +219     
  Branches    17823    17845      +22     
==========================================
+ Hits        58346    58561     +215     
- Misses      48153    48156       +3     
- Partials     1322     1323       +1     
Flag Coverage Δ
server-test 78.50% <96.77%> (+0.12%) ⬆️
unittest 31.25% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@Brooooooklyn Brooooooklyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add some tests

@darkskygit darkskygit force-pushed the darksky/version-check branch 2 times, most recently from 1e876b8 to 6de0745 Compare December 19, 2024 09:47
@darkskygit darkskygit force-pushed the darksky/version-check branch from eb7c0a5 to 6a54784 Compare December 20, 2024 07:34
@darkskygit darkskygit force-pushed the darksky/version-check branch 2 times, most recently from 12b06fa to f95fbe9 Compare December 23, 2024 10:50
@darkskygit darkskygit force-pushed the darksky/version-check branch 2 times, most recently from f91d9a2 to fae6343 Compare December 31, 2024 08:44
@darkskygit darkskygit force-pushed the darksky/version-check branch 2 times, most recently from 7944cb8 to d515b3b Compare January 13, 2025 08:20
@darkskygit darkskygit force-pushed the darksky/version-check branch from d515b3b to 2d14812 Compare January 22, 2025 06:38
@github-actions github-actions bot added the mod:i18n Related to i18n label Feb 4, 2025
@forehalo forehalo force-pushed the darksky/version-check branch from b1e0ba5 to 1cc988d Compare February 11, 2025 06:27
@darkskygit darkskygit force-pushed the darksky/version-check branch from 1cc988d to 2b3a4ac Compare February 12, 2025 00:26
@forehalo forehalo force-pushed the darksky/version-check branch 4 times, most recently from 47c5ab3 to beb8959 Compare February 20, 2025 07:00
@forehalo forehalo force-pushed the darksky/version-check branch from beb8959 to af574df Compare February 20, 2025 07:20
@forehalo forehalo force-pushed the darksky/version-check branch from af574df to a7269ef Compare February 20, 2025 07:28
Copy link

graphite-app bot commented Feb 20, 2025

Merge activity

@forehalo forehalo merged commit fa86f71 into canary Feb 20, 2025
66 checks passed
@forehalo forehalo deleted the darksky/version-check branch February 20, 2025 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core app:server mod:i18n Related to i18n test Related to test cases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants