Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(infra): new workspace infra #5617

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Jan 17, 2024

This PR copying @affine/workspace into common/infra, and adding definitions for services and unit tests.

This was referenced Jan 17, 2024
Copy link

graphite-app bot commented Jan 17, 2024

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

@EYHN EYHN mentioned this pull request Jan 17, 2024
@github-actions github-actions bot added mod:infra Environment related issues and discussions test Related to test cases labels Jan 17, 2024
@EYHN EYHN force-pushed the eyhn/new-workspace-infra branch from fa9fe77 to 155605a Compare January 17, 2024 17:12
@EYHN EYHN force-pushed the eyhn/new-workspace-infra branch from 155605a to c4dbdf7 Compare January 17, 2024 17:48
Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 353 lines in your changes are missing coverage. Please review.

Comparison is base (4f7e0d0) 64.63% compared to head (2e71c98) 64.26%.

Files Patch % Lines
packages/common/infra/src/workspace/engine/blob.ts 21.97% 68 Missing and 3 partials ⚠️
packages/common/infra/src/workspace/upgrade.ts 26.31% 42 Missing ⚠️
...s/common/infra/src/workspace/engine/sync/engine.ts 60.60% 31 Missing and 8 partials ⚠️
...ges/common/infra/src/workspace/engine/sync/peer.ts 75.16% 31 Missing and 6 partials ⚠️
packages/common/infra/src/workspace/list/index.ts 60.00% 24 Missing and 6 partials ⚠️
packages/common/infra/src/workspace/testing.ts 62.02% 28 Missing and 2 partials ⚠️
packages/common/infra/src/workspace/manager.ts 44.68% 24 Missing and 2 partials ⚠️
packages/common/infra/src/utils/object-pool.ts 32.43% 24 Missing and 1 partial ⚠️
packages/common/infra/src/utils/async-queue.ts 70.73% 10 Missing and 2 partials ⚠️
packages/common/infra/src/workspace/workspace.ts 65.62% 10 Missing and 1 partial ⚠️
... and 7 more
Additional details and impacted files
@@                 Coverage Diff                 @@
##           eyhn/fix-vitest    #5617      +/-   ##
===================================================
- Coverage            64.63%   64.26%   -0.38%     
===================================================
  Files                  308      337      +29     
  Lines                18646    19542     +896     
  Branches              1542     1676     +134     
===================================================
+ Hits                 12052    12558     +506     
- Misses                6408     6756     +348     
- Partials               186      228      +42     
Flag Coverage Δ
server-test 70.78% <ø> (ø)
unittest 46.49% <56.31%> (+2.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EYHN EYHN force-pushed the eyhn/new-workspace-infra branch from c4dbdf7 to fefab51 Compare January 19, 2024 06:20
@github-actions github-actions bot added the app:electron Related to electron app label Jan 19, 2024
@EYHN EYHN force-pushed the eyhn/new-workspace-infra branch from fefab51 to ea61059 Compare January 19, 2024 06:22
@EYHN EYHN force-pushed the eyhn/new-workspace-infra branch from ea61059 to 8b77300 Compare January 19, 2024 06:37
@EYHN EYHN force-pushed the eyhn/new-workspace-infra branch 3 times, most recently from 1b21c01 to 76eb4b4 Compare January 19, 2024 06:52
@EYHN EYHN force-pushed the eyhn/new-workspace-infra branch from 76eb4b4 to a05e611 Compare January 22, 2024 04:18
@EYHN EYHN force-pushed the eyhn/new-workspace-infra branch from a05e611 to f2b43a0 Compare January 23, 2024 16:24
@EYHN EYHN force-pushed the eyhn/new-workspace-infra branch from f2b43a0 to 69c4408 Compare January 24, 2024 17:00
@EYHN EYHN force-pushed the eyhn/new-workspace-infra branch from 69c4408 to cdb80ae Compare January 24, 2024 17:51
@EYHN EYHN force-pushed the eyhn/new-workspace-infra branch from cdb80ae to 6d3946e Compare January 25, 2024 03:08
@EYHN EYHN changed the base branch from eyhn/lifecycle to eyhn/fix-vitest January 25, 2024 03:59
@EYHN EYHN force-pushed the eyhn/new-workspace-infra branch from 6d3946e to 2b5b087 Compare January 25, 2024 03:59
@EYHN EYHN force-pushed the eyhn/new-workspace-infra branch from 2b5b087 to 86744a3 Compare January 26, 2024 07:27
@EYHN EYHN force-pushed the eyhn/new-workspace-infra branch from 86744a3 to 9733d86 Compare January 26, 2024 08:15
@EYHN EYHN force-pushed the eyhn/new-workspace-infra branch from 9733d86 to 90bdd03 Compare January 30, 2024 05:47
Copy link

graphite-app bot commented Jan 30, 2024

Merge activity

This PR copying @affine/workspace into common/infra, and adding definitions for services and unit tests.
@EYHN EYHN force-pushed the eyhn/new-workspace-infra branch from 90bdd03 to 2e71c98 Compare January 30, 2024 06:34
@EYHN EYHN changed the base branch from eyhn/fix-vitest to canary January 30, 2024 06:45
@graphite-app graphite-app bot merged commit 2e71c98 into canary Jan 30, 2024
31 of 32 checks passed
@graphite-app graphite-app bot deleted the eyhn/new-workspace-infra branch January 30, 2024 06:46
saranshisatgit pushed a commit to Meta-Root-Zones/AFFiNE that referenced this pull request Jan 30, 2024
This PR copying @affine/workspace into common/infra, and adding definitions for services and unit tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:electron Related to electron app mod:infra Environment related issues and discussions test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants