Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(workspace): split workspace interface and implementation #5463

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Dec 29, 2023

@affine/workspace -> (@affine/workspace, @affine/workspace-impl)

Copy link

graphite-app bot commented Dec 29, 2023

Your org has enabled the Graphite merge queue for merging into canary

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

@github-actions github-actions bot added mod:workspace Related to workspace mod:component test Related to test cases app:core labels Dec 29, 2023
@EYHN EYHN force-pushed the eyhn/refactor/workspace-impl branch 3 times, most recently from e97ac2f to 9c4d036 Compare December 29, 2023 08:05
@EYHN EYHN force-pushed the eyhn/refactor/move-workspace-atom branch from 93e75f9 to dfe34f3 Compare January 2, 2024 07:25
@EYHN EYHN force-pushed the eyhn/refactor/workspace-impl branch from 9c4d036 to c6048b5 Compare January 2, 2024 07:25
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9d0b3b4) 67.04% compared to head (104c21d) 65.06%.

Files Patch % Lines
...frontend/workspace-impl/src/utils/merge-updates.ts 77.77% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary    #5463      +/-   ##
==========================================
- Coverage   67.04%   65.06%   -1.99%     
==========================================
  Files         199      222      +23     
  Lines       15692    16225     +533     
  Branches     1115     1189      +74     
==========================================
+ Hits        10521    10556      +35     
- Misses       5011     5510     +499     
+ Partials      160      159       -1     
Flag Coverage Δ
server-test 69.73% <ø> (ø)
unittest 46.14% <84.61%> (-7.86%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EYHN EYHN force-pushed the eyhn/refactor/move-workspace-atom branch from dfe34f3 to 83ade6e Compare January 2, 2024 07:54
@EYHN EYHN force-pushed the eyhn/refactor/workspace-impl branch from c6048b5 to 4d6e1eb Compare January 2, 2024 07:54
@EYHN EYHN requested review from JimmFly, joooye34 and pengx17 January 2, 2024 07:55
@EYHN EYHN force-pushed the eyhn/refactor/move-workspace-atom branch from 83ade6e to d653a1b Compare January 2, 2024 09:57
@EYHN EYHN force-pushed the eyhn/refactor/workspace-impl branch from 4d6e1eb to 4b36568 Compare January 2, 2024 09:57
@EYHN EYHN force-pushed the eyhn/refactor/move-workspace-atom branch from d653a1b to 9d0b3b4 Compare January 2, 2024 10:06
@EYHN EYHN changed the base branch from eyhn/refactor/move-workspace-atom to canary January 2, 2024 10:15
@EYHN EYHN force-pushed the eyhn/refactor/workspace-impl branch from 4b36568 to e1cdc20 Compare January 2, 2024 10:15
Copy link
Member Author

EYHN commented Jan 2, 2024

Merge activity

@EYHN EYHN force-pushed the eyhn/refactor/workspace-impl branch from e1cdc20 to 42104f4 Compare January 2, 2024 10:45
)

@affine/workspace -> (@affine/workspace, @affine/workspace-impl)
@EYHN EYHN force-pushed the eyhn/refactor/workspace-impl branch from 42104f4 to 104c21d Compare January 2, 2024 10:58
@graphite-app graphite-app bot merged commit 104c21d into canary Jan 2, 2024
@graphite-app graphite-app bot deleted the eyhn/refactor/workspace-impl branch January 2, 2024 11:34
@EYHN EYHN mentioned this pull request Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:component mod:workspace Related to workspace test Related to test cases
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants