Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(editor): remove non null asserts in turbo renderer #10454

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

doodlewind
Copy link
Member

No description provided.

Copy link
Member Author

doodlewind commented Feb 26, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@doodlewind doodlewind marked this pull request as ready for review February 26, 2025 14:44
@doodlewind doodlewind requested a review from a team as a code owner February 26, 2025 14:44
@graphite-app graphite-app bot requested review from a team February 26, 2025 14:44
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.

Project coverage is 54.27%. Comparing base (3252dd7) to head (b906eb5).
Report is 2 commits behind head on canary.

Files with missing lines Patch % Lines
.../shared/src/viewport-renderer/viewport-renderer.ts 69.23% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           canary   #10454   +/-   ##
=======================================
  Coverage   54.27%   54.27%           
=======================================
  Files        2341     2341           
  Lines      108234   108231    -3     
  Branches    17906    17906           
=======================================
- Hits        58742    58741    -1     
+ Misses      48170    48168    -2     
  Partials     1322     1322           
Flag Coverage Δ
server-test 78.95% <ø> (+<0.01%) ⬆️
unittest 31.21% <69.23%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@doodlewind doodlewind changed the base branch from doodl/vtr to graphite-base/10454 February 27, 2025 02:10
Copy link

graphite-app bot commented Feb 27, 2025

Merge activity

@graphite-app graphite-app bot changed the base branch from graphite-base/10454 to canary February 27, 2025 02:25
@doodlewind doodlewind merged commit e9484e8 into canary Feb 27, 2025
66 checks passed
@doodlewind doodlewind deleted the doodl/vtr-2 branch February 27, 2025 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants