Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(editor): use transformer from store when possible #10453

Conversation

Saul-Mirone
Copy link
Contributor

No description provided.

@Saul-Mirone Saul-Mirone marked this pull request as ready for review February 26, 2025 13:40
@Saul-Mirone Saul-Mirone requested a review from a team as a code owner February 26, 2025 13:40
@graphite-app graphite-app bot requested review from a team February 26, 2025 13:40
Copy link
Contributor Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 15.78947% with 16 lines in your changes missing coverage. Please review.

Project coverage is 54.29%. Comparing base (1c5e360) to head (fd6d96a).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
...locksuite/framework/store/src/model/store/store.ts 40.00% 3 Missing ⚠️
...ine/block-root/src/edgeless/clipboard/clipboard.ts 0.00% 2 Missing ⚠️
...ite/affine/block-root/src/transformers/markdown.ts 0.00% 2 Missing ⚠️
...ontend/core/src/blocksuite/utils/markdown-utils.ts 0.00% 2 Missing ⚠️
...ffine/block-root/src/edgeless/services/template.ts 0.00% 1 Missing ⚠️
...ffine/block-root/src/edgeless/utils/clone-utils.ts 0.00% 1 Missing ⚠️
...cksuite/affine/block-root/src/transformers/html.ts 0.00% 1 Missing ⚠️
...e/affine/shared/src/services/drag-handle-config.ts 0.00% 1 Missing ⚠️
...get-drag-handle/src/watchers/drag-event-watcher.ts 0.00% 1 Missing ⚠️
...cksuite/framework/block-std/src/clipboard/index.ts 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           canary   #10453      +/-   ##
==========================================
+ Coverage   54.27%   54.29%   +0.01%     
==========================================
  Files        2342     2342              
  Lines      108205   108172      -33     
  Branches    17885    17884       -1     
==========================================
- Hits        58731    58729       -2     
+ Misses      48154    48112      -42     
- Partials     1320     1331      +11     
Flag Coverage Δ
server-test 78.95% <ø> (-0.01%) ⬇️
unittest 31.23% <10.52%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Feb 26, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 02-26-refactor_editor_use_transformer_from_store_when_possible branch from 29fd91b to fd6d96a Compare February 26, 2025 14:15
@graphite-app graphite-app bot merged commit fd6d96a into canary Feb 26, 2025
66 checks passed
@graphite-app graphite-app bot deleted the 02-26-refactor_editor_use_transformer_from_store_when_possible branch February 26, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants