Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(core): only full sync before exporting #10408

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Conversation

forehalo
Copy link
Member

No description provided.

@graphite-app graphite-app bot requested review from a team February 24, 2025 11:40
@github-actions github-actions bot added mod:i18n Related to i18n app:core labels Feb 24, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 33 lines in your changes missing coverage. Please review.

Project coverage is 54.22%. Comparing base (c644a46) to head (019cf9e).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
packages/common/nbstore/src/sync/blob/index.ts 41.50% 31 Missing ⚠️
packages/common/nbstore/src/frontend/blob.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary   #10408      +/-   ##
==========================================
- Coverage   54.22%   54.22%   -0.01%     
==========================================
  Files        2340     2340              
  Lines      108164   108170       +6     
  Branches    17889    17889              
==========================================
+ Hits        58650    58652       +2     
- Misses      48185    48193       +8     
+ Partials     1329     1325       -4     
Flag Coverage Δ
server-test 78.95% <ø> (+<0.01%) ⬆️
unittest 31.17% <25.45%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@forehalo forehalo force-pushed the 61/fullsync-before-export branch 2 times, most recently from 9678ecc to 7630b39 Compare February 25, 2025 03:11
Copy link

graphite-app bot commented Feb 25, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 61/fullsync-before-export branch from 7630b39 to c7cb7ae Compare February 25, 2025 04:14
@graphite-app graphite-app bot force-pushed the 61/fullsync-before-export branch from c7cb7ae to 019cf9e Compare February 25, 2025 04:27
@forehalo forehalo enabled auto-merge (squash) February 25, 2025 04:29
@forehalo forehalo merged commit e5e5c0a into canary Feb 25, 2025
66 checks passed
@forehalo forehalo deleted the 61/fullsync-before-export branch February 25, 2025 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app:core mod:i18n Related to i18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants