Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nbstore): fix doc sync logic #10400

Merged
merged 1 commit into from
Feb 24, 2025
Merged

fix(nbstore): fix doc sync logic #10400

merged 1 commit into from
Feb 24, 2025

Conversation

EYHN
Copy link
Member

@EYHN EYHN commented Feb 24, 2025

No description provided.

@EYHN EYHN marked this pull request as ready for review February 24, 2025 09:09
@graphite-app graphite-app bot requested review from a team February 24, 2025 09:09
Copy link
Member Author

EYHN commented Feb 24, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 54.23%. Comparing base (378bb37) to head (59a791f).
Report is 1 commits behind head on canary.

Files with missing lines Patch % Lines
packages/common/nbstore/src/sync/doc/peer.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           canary   #10400      +/-   ##
==========================================
- Coverage   54.23%   54.23%   -0.01%     
==========================================
  Files        2340     2340              
  Lines      108152   108154       +2     
  Branches    17887    17885       -2     
==========================================
- Hits        58653    58652       -1     
- Misses      48170    48173       +3     
  Partials     1329     1329              
Flag Coverage Δ
server-test 78.95% <ø> (-0.02%) ⬇️
unittest 31.19% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

graphite-app bot commented Feb 24, 2025

Merge activity

@graphite-app graphite-app bot merged commit 59a791f into canary Feb 24, 2025
66 checks passed
@graphite-app graphite-app bot deleted the eyhn/fix/sync-bug branch February 24, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants