fix(editor): using click event instead of pointerDown event for page block #10351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## canary #10351 +/- ##
=======================================
Coverage 54.41% 54.41%
=======================================
Files 2335 2335
Lines 107935 107921 -14
Branches 17822 17817 -5
=======================================
- Hits 58733 58728 -5
+ Misses 47876 47857 -19
- Partials 1326 1336 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
L-Sun
changed the title
L-Sun
force-pushed
the
l-sun/refactor/page-block-click
branch
from
567d7de to
ea223d0
Compare
L-Sun
force-pushed
the
l-sun/refactor/page-block-click
branch
from
ea223d0 to
bc02398
Compare
L-Sun
force-pushed
the
l-sun/refactor/page-block-click
branch
from
bc02398 to
5e0d728
Compare
Saul-Mirone
approved these changes
Feb 21, 2025
Merge activity
|
…block (#10351) Close [BS-2647](https://linear.app/affine-design/issue/BS-2647/ios返回手势会误触发focus导致弹起键盘) ### What Changes: - Using `click` event instead of `pointerDown` event to handle selection logic in page block, because gestures on mobile devices can trigger the `pointerDown` event, causing the cursor to update and unexpectedly bring up the virtual keyboard.
graphite-app
bot
force-pushed
the
l-sun/refactor/page-block-click
branch
from
5e0d728 to
72b7519
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close BS-2647
What Changes:
clickevent instead ofpointerDownevent to handle selection logic in page block, because gestures on mobile devices can trigger thepointerDownevent, causing the cursor to update and unexpectedly bring up the virtual keyboard.