Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): blocksuite editor runtime configs in correct timing #10344

Conversation

pengx17
Copy link
Collaborator

@pengx17 pengx17 commented Feb 21, 2025

No description provided.

@pengx17 pengx17 marked this pull request as ready for review February 21, 2025 07:45
@graphite-app graphite-app bot requested review from a team February 21, 2025 07:45
Copy link
Collaborator Author

pengx17 commented Feb 21, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@pengx17 pengx17 force-pushed the xp/02-21-fix_core_blocksuite_editor_runtime_configs_in_correct_timing branch from 22caba1 to cd39cbe Compare February 21, 2025 07:49
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.42%. Comparing base (244d683) to head (e81eb7a).
Report is 4 commits behind head on canary.

Additional details and impacted files
@@            Coverage Diff             @@
##           canary   #10344      +/-   ##
==========================================
- Coverage   54.42%   54.42%   -0.01%     
==========================================
  Files        2330     2330              
  Lines      107956   107958       +2     
  Branches    17824    17825       +1     
==========================================
+ Hits        58756    58757       +1     
- Misses      47873    47874       +1     
  Partials     1327     1327              
Flag Coverage Δ
server-test 78.70% <ø> (-0.01%) ⬇️
unittest 31.34% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pengx17 pengx17 force-pushed the xp/02-21-fix_core_blocksuite_editor_runtime_configs_in_correct_timing branch from cd39cbe to e81eb7a Compare February 21, 2025 08:56
Copy link

graphite-app bot commented Feb 21, 2025

Merge activity

@forehalo forehalo merged commit dff68b9 into canary Feb 21, 2025
66 checks passed
@forehalo forehalo deleted the xp/02-21-fix_core_blocksuite_editor_runtime_configs_in_correct_timing branch February 21, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants