refactor(editor): move editor components to frontend core #10335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Saul-Mirone
changed the title
Saul-Mirone
force-pushed
the
02-21-refactor_editor_remove_ref_to_affineeditorcontiner
branch
2 times, most recently
from
cc47be2 to
e351bad
Compare
CatsJuice
approved these changes
Feb 21, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## canary #10335 +/- ##
==========================================
+ Coverage 54.36% 54.37% +0.01%
==========================================
Files 2336 2334 -2
Lines 108103 108055 -48
Branches 17854 17848 -6
==========================================
- Hits 58769 58758 -11
+ Misses 48011 47974 -37
Partials 1323 1323
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Saul-Mirone
force-pushed
the
02-21-refactor_editor_remove_ref_to_affineeditorcontiner
branch
from
e351bad to
2683c12
Compare
Merge activity
|
### TL;DR Moved editor components from BlockSuite presets to AFFiNE core and updated imports accordingly. ### What changed? - Relocated `EdgelessEditor` and `PageEditor` components from BlockSuite presets to AFFiNE core - Removed basic editor examples from playground - Updated import paths across the codebase to reference new component locations - Added editor effects registration in AFFiNE core - Removed editor exports from BlockSuite presets ### How to test? 1. Launch the application 2. Verify both page and edgeless editors load correctly 3. Confirm editor functionality remains intact including: - Document editing - Mode switching - Editor toolbars and controls - Multiple editor instances ### Why make this change? This change better aligns with AFFiNE's architecture by moving editor components closer to where they are used. It reduces coupling with BlockSuite presets and gives AFFiNE more direct control over editor customization and implementation.
graphite-app
bot
force-pushed
the
02-21-refactor_editor_remove_ref_to_affineeditorcontiner
branch
from
2683c12 to
adcc6b5
Compare
graphite-app
bot
deleted the
02-21-refactor_editor_remove_ref_to_affineeditorcontiner
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Moved editor components from BlockSuite presets to AFFiNE core and updated imports accordingly.
What changed?
EdgelessEditorandPageEditorcomponents from BlockSuite presets to AFFiNE coreHow to test?
Why make this change?
This change better aligns with AFFiNE's architecture by moving editor components closer to where they are used. It reduces coupling with BlockSuite presets and gives AFFiNE more direct control over editor customization and implementation.